ChenSammi commented on code in PR #4538: URL: https://github.com/apache/ozone/pull/4538#discussion_r1172137337
########## hadoop-ozone/dist/src/main/smoketest/security/get-S3-secret.robot: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Documentation Smoke test to start cluster with docker-compose environments. +Library OperatingSystem +Library String +Library BuiltIn +Resource ../commonlib.robot +Test Timeout 2 minutes + +*** Keywords *** +GetSecret success + Run Keyword Kinit test user testuser testuser.keytab + ${output}= Execute ozone s3 getsecret + Should contain ${output} awsAccessKey + Should contain ${output} awsSecret + Execute kdestroy + +GetSecret failure + Run Keyword Kinit test user testuser testuser.keytab + ${output2}= Execute and Ignore Error ozone s3 getsecret + Should not contain ${output2} awsAccessKey + Should not contain ${output2} awsSecret + Should contain ${output2} S3_SECRET_ALREADY_EXISTS Review Comment: bash-4.2$ ozone s3 getsecret --om-service-id=omservice S3_SECRET_ALREADY_EXISTS Secret for 'testuser/[email protected]' already exists Please don't show the S3_SECRET_ALREADY_EXISTS in the output. "Secret for 'testuser/[email protected]' already exists" is good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
