ChenSammi commented on code in PR #4559:
URL: https://github.com/apache/ozone/pull/4559#discussion_r1174969575
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/GetAclBucketHandler.java:
##########
@@ -32,9 +38,41 @@ public class GetAclBucketHandler extends GetAclHandler {
@CommandLine.Mixin
private BucketUri address;
+ private enum BucketType { SOURCE, TARGET }
+
+ @CommandLine.Option(names = { "--type", "-t" },
+ defaultValue = "SOURCE",
+ description = "Allowed Bucket Type: ${COMPLETION-CANDIDATES}")
+ private BucketType linkBucketType;
Review Comment:
I would suggest change the option to "--follow", "-f".
If "-f" is not specified, then link bucket ACL itself will be displayed,
otherwise source bucket ACL will be displayed.
Also for this ${COMPLETION-CANDIDATES}, I didn't find how it is processed,
but the its content is
"FILE_SYSTEM_OPTIMIZED, OBJECT_STORE, LEGACY", which is not what we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
