ChenSammi commented on code in PR #4559:
URL: https://github.com/apache/ozone/pull/4559#discussion_r1174970479
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java:
##########
@@ -152,15 +152,22 @@ public boolean checkAccess(OzoneObj ozObject,
RequestContext context)
Objects.requireNonNull(ozObject);
Objects.requireNonNull(context);
- ResolvedBucket resolvedBucket;
- try {
- resolvedBucket = ozoneManager.resolveBucketLink(
- Pair.of(ozObject.getVolumeName(), ozObject.getBucketName()), false);
- } catch (IOException e) {
- throw new OMException("Failed to resolveBucketLink:", e, INTERNAL_ERROR);
+ String volume;
+ String bucket;
+ if (context.getAclRights() == ACLType.DELETE) {
Review Comment:
Besides DELETE, for ACL_READ, we also should check link bucket's ACL, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
