Pochatkin commented on code in PR #4389:
URL: https://github.com/apache/ozone/pull/4389#discussion_r1176054302
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -754,8 +758,27 @@ private void instantiateServices(boolean withNewSnapshot)
throws IOException {
}
volumeManager = new VolumeManagerImpl(metadataManager);
bucketManager = new BucketManagerImpl(metadataManager);
+
+ Class<? extends S3SecretStoreProvider> storeProviderClass =
+ configuration.getClass(
+ S3_SECRET_STORAGE_TYPE,
+ DEFAULT_SECRET_STORAGE_TYPE,
+ S3SecretStoreProvider.class);
+ S3SecretStore store;
+ try {
+ store = storeProviderClass == DEFAULT_SECRET_STORAGE_TYPE
+ ? metadataManagerImpl
Review Comment:
I don't think it's our responsibility. Because in the general case, we
simply cannot guarantee that this is possible. Let's imagine that in the future
some 3 types of storage appear, the user configures it, but he also removes
everything related to vault from the configuration and we simply lose access to
the old storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
