Pochatkin commented on code in PR #4389:
URL: https://github.com/apache/ozone/pull/4389#discussion_r1176054494
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManagerImpl.java:
##########
@@ -64,6 +69,10 @@ public String getSecretString(String awsAccessKey)
"awsAccessKeyId cannot be null or empty.");
LOG.trace("Get secret for awsAccessKey:{}", awsAccessKey);
+ S3SecretValue cacheValue = s3SecretCache.get(awsAccessKey);
+ if (cacheValue != null) {
+ return cacheValue.getAwsSecret();
+ }
S3SecretValue s3Secret = s3SecretStore.getSecret(awsAccessKey);
Review Comment:
Fixed in last commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
