ChenSammi commented on PR #4583: URL: https://github.com/apache/ozone/pull/4583#issuecomment-1522900606
> > can we reuse the ""hdds.datanode.storage.utilization.critical.threshold" property? > > Thanks @ChenSammi for the comment, Now that I have changed the current patch to use capacity, should I still change it to use this property as hdds.datanode.storage.utilization.critical.threshold takes a float that represents percentage. Also another thing I noticed is that this property is redundant and not used anywhere except to filter output in the SCM JMX , If we don't rename it here , I feel we can remove this property as it can be misleading as configuring it does nothing. Hi @sadanand48 , we already have following properties in Ozone now. 1. hdds.datanode.dir.du.reserved //storage space 2. hdds.datanode.dir.du.reserved.percent // storage percentage 3. hdds.datanode.storage.utilization.warning.threshold // threshold 4. hdds.datanode.storage.utilization.critical.threshold // threshold From user's point of view, "hdds.datanode.volume.min.free.space" looks very similar to "hdds.datanode.dir.du.reserved" functionally, like another kind of reserved space. Maybe we can use "hdds.datanode.dir.du.reserved" directly? Currently the default value of "hdds.datanode.dir.du.reserved" and " hdds.datanode.dir.du.reserved.percent" are 0. We can change their default value(5GB, like in this patch, and 0.95 for percent), what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
