hemantk-12 commented on code in PR #4633:
URL: https://github.com/apache/ozone/pull/4633#discussion_r1183042652
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -155,9 +158,8 @@ public class SnapshotDiffManager implements AutoCloseable {
*/
private final String sstBackupDirForSnapDiffJobs;
- private boolean isNativeRocksToolsLoaded;
-
- private ManagedSSTDumpTool sstDumpTool;
+ private final boolean isNativeRocksToolsLoaded;
Review Comment:
Yes, we can use `Optional` but it will require some changes in
[addToObjectIdMap](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java#L741).
I'll leave it as it is in this PR and will address in
[PR-4617](https://github.com/apache/ozone/pull/4617) since I already did some
refactoring in that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
