hemantk-12 commented on code in PR #4633:
URL: https://github.com/apache/ozone/pull/4633#discussion_r1183043146
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSstFileReader.java:
##########
@@ -49,16 +49,37 @@ public class ManagedSstFileReader {
private final Collection<String> sstFiles;
+ private volatile long estimatedTotalKeys = -1;
+
public ManagedSstFileReader(final Collection<String> sstFiles) {
this.sstFiles = sstFiles;
}
public static <T> Stream<T> getStreamFromIterator(ClosableIterator<T> itr) {
final Spliterator<T> spliterator =
Spliterators.spliteratorUnknownSize(itr, 0);
- return StreamSupport.stream(spliterator, false).onClose(() -> {
- itr.close();
- });
+ return StreamSupport.stream(spliterator, false).onClose(itr::close);
+ }
+
+ public long getEstimatedTotalKeys() throws RocksDBException {
+ if (estimatedTotalKeys != -1) {
+ return estimatedTotalKeys;
+ }
+
+ long estimatedSize = 0;
+ synchronized (this) {
+ try (ManagedOptions options = new ManagedOptions()) {
+ for (String sstFile : sstFiles) {
+ SstFileReader fileReader = new SstFileReader(options);
+ fileReader.open(sstFile);
+ estimatedSize += fileReader.getTableProperties().getNumEntries();
Review Comment:
Thanks, I'll update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
