DaveTeng0 commented on code in PR #4634:
URL: https://github.com/apache/ozone/pull/4634#discussion_r1183073562
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1218,8 +1219,18 @@ private GetS3VolumeContextResponse getS3VolumeContext()
return impl.getS3VolumeContext().getProtobuf();
}
+ @DisallowedUntilLayoutVersion(SNAPSHOT_SUPPORT)
private SnapshotDiffResponse snapshotDiff(
SnapshotDiffRequest snapshotDiffRequest) throws IOException {
+ if (!getOzoneManager().getVersionManager()
+ .isAllowed(SNAPSHOT_SUPPORT)) {
+ throw new OMException(
+ "cannot be invoked before finalization.",
+ OMException.ResultCodes.
+ NOT_SUPPORTED_OPERATION_PRIOR_FINALIZATION)
+ ;
+ }
+
Review Comment:
Yes good catch! Definitely we should will do so! Thanks Hemant!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
