DaveTeng0 commented on code in PR #4634:
URL: https://github.com/apache/ozone/pull/4634#discussion_r1184121160
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/callbacks/common/callback.sh:
##########
@@ -35,12 +35,26 @@ validate() {
execute_robot_test "$SCM" -v PREFIX:"$1" ${@:2} upgrade/validate.robot
}
+## @description Validates that if cluster supports snapshot feature.
+## @param Whether the snapshot feature should be supported in cluster.
+## @param All parameters after the first one are passed directly to the robot
command,
+## see
https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#all-command-line-options
+validate_snapshot_support() {
+ TEST_TAG="snapshot-non-support"
+ if [ "$1" = "true" ];
+ then
+ TEST_TAG="snapshot-support"
+ fi;
+ execute_robot_test --include $TEST_TAG -v ${@:2} upgrade/snapshot.robot
Review Comment:
Yup thanks attila, I moved these validation tests into folder of 1.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
