adoroszlai commented on PR #4664: URL: https://github.com/apache/ozone/pull/4664#issuecomment-1537204821
With Ratis 2.5.1, block is deleted contrary to test expectations. This results in two kinds of failures, depending on timing: https://github.com/apache/ozone/blob/7f7ec2397ac029cf2a8bc8490b7ecafb34020b0d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java#L305-L306 https://github.com/apache/ozone/blob/7f7ec2397ac029cf2a8bc8490b7ecafb34020b0d/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java#L307-L317 When block deletion reaches the following condition: https://github.com/apache/ozone/blob/7f7ec2397ac029cf2a8bc8490b7ecafb34020b0d/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java#L223-L232 with Ratis 2.5.1 `minReplicatedIndex` is always -1 (I guess due to [RATIS-1767](https://issues.apache.org/jira/browse/RATIS-1767), but could be wrong), so deletion is allowed. I think the `minReplicatedIndex >= 0` condition is wrong. If `minReplicatedIndex == -1`, then we should not allow deleting the blocks, so I removed that condition. Test passes locally. Pushed new commit, waiting for CI in fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
