smengcl commented on code in PR #4664:
URL: https://github.com/apache/ozone/pull/4664#discussion_r1187978967
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java:
##########
@@ -220,7 +220,7 @@ private boolean isDeletionAllowed(ContainerData
containerData,
long minReplicatedIndex =
ratisServer.getMinReplicatedIndex(pipelineID);
long containerBCSID = containerData.getBlockCommitSequenceId();
- if (minReplicatedIndex >= 0 && minReplicatedIndex < containerBCSID) {
Review Comment:
~~Is this intended? `minReplicatedIndex` could be `-1`, thus getting rid of
the `minReplicatedIndex >= 0` condition here changes the logic slightly.~~ oh I
should've read the comment above first:
https://github.com/apache/ozone/pull/4664#issuecomment-1537204821
cc @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
