smengcl commented on code in PR #4678:
URL: https://github.com/apache/ozone/pull/4678#discussion_r1190323665
##########
hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedSSTDumpIterator.java:
##########
@@ -244,40 +223,45 @@ protected void finalize() throws Throwable {
* Class containing Parsed KeyValue Record from Sst Dumptool output.
*/
public static final class KeyValue {
- private String key;
- private Integer sequence;
+ private byte[] key;
+ private BigInteger sequence;
Review Comment:
Is `Long` sufficient here? `BigInteger` iirc is a lot slower than `Long` or
`Integer`. It is concerning when it is used as a counter in the iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
