DaveTeng0 commented on code in PR #4678:
URL: https://github.com/apache/ozone/pull/4678#discussion_r1192858926
##########
hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedSSTDumpIterator.java:
##########
@@ -43,21 +42,16 @@
private static final Logger LOG =
LoggerFactory.getLogger(ManagedSSTDumpIterator.class);
- // Since we don't have any restriction on the key, we are prepending
+ // Since we don't have any restriction on the key & value, we are prepending
// the length of the pattern in the sst dump tool output.
// The first token in the pattern is the key.
// The second tells the sequence number of the key.
// The third token gives the type of key in the sst file.
- private static final String PATTERN_REGEX =
- "'([\\s\\S]+)' seq:([0-9]+), type:([0-9]+)";
- public static final int PATTERN_KEY_GROUP_NUMBER = 1;
- public static final int PATTERN_SEQ_GROUP_NUMBER = 2;
- public static final int PATTERN_TYPE_GROUP_NUMBER = 3;
- private static final Pattern PATTERN_MATCHER =
Pattern.compile(PATTERN_REGEX);
- private BufferedReader processOutput;
- private KeyValue currentKey;
- private char[] charBuffer;
- private KeyValue nextKey;
+ // The fourth token
Review Comment:
Hey swami, what is the fourth token?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
