swamirishi commented on code in PR #4708:
URL: https://github.com/apache/ozone/pull/4708#discussion_r1195823429


##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/TestOMFileCreateRequest.java:
##########
@@ -334,6 +337,30 @@ public void 
testValidateAndUpdateCacheWithNonRecursiveAndOverWrite()
     testNonRecursivePath(key, false, false, true);
   }
 
+  @Test
+  public void testPreExecuteWithInvalidKeyPrefix() throws Exception {
+    String[] invalidKeyNames = {OM_SNAPSHOT_INDICATOR + "/" + keyName,
+        OM_SNAPSHOT_INDICATOR + "/a/" + keyName,

Review Comment:
   Can you also add a test case with .snapshotabc/a/b/c, this should pass. This 
should be a valid key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to