hemantk-12 commented on code in PR #4708:
URL: https://github.com/apache/ozone/pull/4708#discussion_r1198365304


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java:
##########
@@ -94,6 +96,12 @@ public OMRequest preExecute(OzoneManager ozoneManager) 
throws IOException {
     KeyArgs keyArgs = createFileRequest.getKeyArgs();
 
     // Verify key name
+    if (keyArgs.getKeyName()

Review Comment:
   nit: this can be moved to `OmUtils` similar to 
[validateKeyName](https://github.com/apache/ozone/blob/3dd6e29f2deb1d27aef2e82fcf9ef962e996cc03/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java#L596)
 and reused it here and in `OMKeyCreateRequest`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to