sumitagrawl commented on code in PR #4688:
URL: https://github.com/apache/ozone/pull/4688#discussion_r1195901849
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/lease/LeaseManager.java:
##########
@@ -204,9 +205,8 @@ public void shutdown() {
checkStatus();
LOG.debug("Shutting down LeaseManager service");
leaseMonitor.disable();
- synchronized (monitor) {
Review Comment:
@szetszwo currently I have reverted this as shutdown is threadsafe. Adding
synchronization needs protect all member variables as findbug, which is not
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
