dombizita commented on code in PR #4724:
URL: https://github.com/apache/ozone/pull/4724#discussion_r1200474174
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/ContainersResponse.java:
##########
@@ -60,16 +61,24 @@ public static class ContainersResponseData {
@JsonProperty("totalCount")
private long totalCount;
+ /**
+ * prevKey will be the last key of the previous page.
+ */
+ @JsonProperty("prevKey")
+ private long prevKey;
+
Review Comment:
in this class you reference it as `prevKey` but in the `ContainerEndpoint`
when you are passing it you say `lastContainerID` (also in the jira description
is says it this way)
https://github.com/apache/ozone/blob/d2c3b4aad073f9b28ee30f3c80cf12c6f4247326/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java#L161-L163
shouldn't we use `lastContainerID` here as well? `prevKey` seems a bit hard
to understand at first, or maybe just document the change better.
let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
