ArafatKhan2198 commented on code in PR #4724:
URL: https://github.com/apache/ozone/pull/4724#discussion_r1201954000
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -141,9 +140,12 @@ public Response getContainers(
// Send back an empty response
return Response.status(Response.Status.NOT_ACCEPTABLE).build();
}
+
long containersCount;
- Collection<ContainerMetadata> containerMetaDataList =
- containerManager.getContainers(ContainerID.valueOf(prevKey), limit)
+ List<ContainerMetadata> containerMetaDataList =
+ // Get the containers starting from the prevKey+1 which will skip the
+ // container having prevKey ID
+ containerManager.getContainers(ContainerID.valueOf(prevKey + 1), limit)
Review Comment:
No, currently we have no UI components that are utilizing this specific
endpoints alone `http://localhost:9888/api/v1/containers/` but we do have UI
components that utilize this UI path such as
`http://localhost:9888/api/v1/containers/unhealthy` but the changes that we
have made does not impact them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
