devmadhuu commented on code in PR #4755:
URL: https://github.com/apache/ozone/pull/4755#discussion_r1201515545
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
"/task/status": "/taskStatus",
- "/containers/unhealthy": "/unhealthyContainers"
+ "/containers/unhealthy": "/unhealthyContainers",
+
"/heatmap/readaccess?startDate=24H&path=/hivevolTest1/hivebucketTest2&entityType=*":
"/heatmapTestClick",
Review Comment:
@smitajoshi12 Thanks for working on this patch. However above heatmap link
route should be executed only based on flag, when you get the flag to make it
visible from backend.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/navBar/navBar.tsx:
##########
@@ -28,9 +28,17 @@ const {Sider} = Layout;
interface INavBarProps extends RouteComponentProps<object> {
collapsed: boolean;
onCollapse: (arg: boolean) => void;
+ flag: boolean;
Review Comment:
Pls change the name of this variable something like: isHeatMapAvailable
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
"/task/status": "/taskStatus",
- "/containers/unhealthy": "/unhealthyContainers"
+ "/containers/unhealthy": "/unhealthyContainers",
+
"/heatmap/readaccess?startDate=24H&path=/hivevolTest1/hivebucketTest2&entityType=*":
"/heatmapTestClick",
Review Comment:
We should not hardcode any path here. Pass default values for all 3 params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
