dombizita commented on code in PR #4755:
URL: https://github.com/apache/ozone/pull/4755#discussion_r1215376172
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/package.json:
##########
@@ -35,7 +38,7 @@
},
"scripts": {
"start": "react-app-rewired start",
- "build": "react-app-rewired build",
+ "build": "react-app-rewired --max_old_space_size=4096 build",
Review Comment:
is this removed because of the previous **build (8)** issue? did you check
the history why it was there? maybe @adoroszlai do you know anything about this?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/navBar/navBar.tsx:
##########
@@ -28,9 +28,17 @@ const {Sider} = Layout;
interface INavBarProps extends RouteComponentProps<object> {
collapsed: boolean;
onCollapse: (arg: boolean) => void;
+ isheatmapavailable: boolean;
Review Comment:
```suggestion
isHeatmapAvailable: boolean;
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/navBar/navBar.tsx:
##########
@@ -28,9 +28,17 @@ const {Sider} = Layout;
interface INavBarProps extends RouteComponentProps<object> {
collapsed: boolean;
onCollapse: (arg: boolean) => void;
+ isheatmapavailable: boolean;
}
class NavBar extends React.Component<INavBarProps> {
+ constructor(props = {}) {
+ super(props);
+ this.state = {
+ isheatmapavailable: false
Review Comment:
I can't see that you did the changes suggested by @devmadhuu
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -23,5 +23,9 @@
"/namespace/summary?path=*": "/metadata",
"/namespace/quota?path=*": "/quota",
"/task/status": "/taskStatus",
- "/containers/unhealthy": "/unhealthyContainers"
+ "/containers/unhealthy": "/unhealthyContainers",
+ "/heatmap/readaccess?startDate=90D&path=*&entityType=*": "/heatmapTestClick",
Review Comment:
is this necessary? I can't see it used anywhere else
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/navBar/navBar.tsx:
##########
@@ -81,6 +89,14 @@ class NavBar extends React.Component<INavBarProps> {
<span>Disk Usage</span>
<Link to='/DiskUsage'/>
</Menu.Item>
+ {
+ this.state.isheatmapavailable ?
+ <Menu.Item key='/HeatMap'>
+ <Icon type='bar-chart' />
+ <span>HeatMap</span>
Review Comment:
shouldn't it be Heatmap? previously I saw it with this spelling.
cc @devmadhuu
```suggestion
<span>Heatmap</span>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
