adoroszlai commented on code in PR #4678:
URL: https://github.com/apache/ozone/pull/4678#discussion_r1214204408
##########
.github/workflows/ci.yml:
##########
@@ -171,14 +171,10 @@ jobs:
check: ${{ fromJson(needs.build-info.outputs.basic-checks) }}
fail-fast: false
steps:
- - name: Checkout project
- uses: actions/checkout@v3
- if: matrix.check != 'bats'
- name: Checkout project with history
uses: actions/checkout@v3
with:
fetch-depth: 0
- if: matrix.check == 'bats'
Review Comment:
If I understand correctly, only `unit` check needs git history (in addition
to `bats`). So instead of removing the if conditions, please add `unit` to
them.
##########
hadoop-ozone/dist/src/main/smoketest/snapshot/upgrade-snapshot-check.robot:
##########
@@ -74,13 +74,18 @@ Attempt to snapshotDiff when snapshot feature is disabled
${output} = Execute and checkrc ozone sh snapshot
snapshotDiff /snapvolume-2/snapbucket-1 snapshot1 snapshot2 255
Should contain ${output} NOT_SUPPORTED_OPERATION
-# HDDS-8732
-#Delete snapshot
-# [Tags] finalized-snapshot-tests
-# ${output} = Execute ozone sh snapshot delete
/snapvolume-1/snapbucket-1 snapshot1
-# Should not contain ${output} Failed
-# ${output} = Execute ozone sh snapshot ls
/snapvolume-1/snapbucket-1
-# Should contain ${output}
SNAPSHOT_DELETED
+Delete snapshot
+ [Tags] finalized-snapshot-tests
+ ${output} = Execute ozone sh snapshot delete
/snapvolume-1/snapbucket-1 snapshot1
+ Should not contain ${output} Failed
+ WHILE True
+ ${output} = Execute ozone sh snapshot ls
/snapvolume-1/snapbucket-1 jq '[.[] | select(.name == "snapshot1") |
.snapshotStatus] | if length > 0 then .[] else "SNAPSHOT_DELETED" end'
+ IF "SNAPSHOT_DELETED" in """${output}"""
+ BREAK
+ ELSE
+ 10s
+ END
+ END
Review Comment:
Please use `Wait Until Keyword Succeeds` builtin instead of the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
