ChenSammi commented on code in PR #4808:
URL: https://github.com/apache/ozone/pull/4808#discussion_r1221108990
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/ssl/ReloadingX509TrustManager.java:
##########
@@ -138,7 +139,8 @@ X509TrustManager loadTrustManager(CertificateClient
caClient)
X509TrustManager trustManager = null;
KeyStore ks = KeyStore.getInstance(type);
ks.load(null, null);
- ks.setCertificateEntry(rootCACertId, rootCACert);
+ insertCertsToKeystore(caClient.getAllRootCaCerts(), ks);
+ insertCertsToKeystore(caClient.getAllCaCerts(), ks);
Review Comment:
With the certificate bundle supported, we only need root CA certificates in
the trust store, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
