fapifta commented on code in PR #4808:
URL: https://github.com/apache/ozone/pull/4808#discussion_r1222563259
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/CertificateClient.java:
##########
@@ -110,19 +111,25 @@ X509Certificate getCertificate(String certSerialId)
* Return all certificates in this component's trust chain,
* the last one is the root CA certificate.
*/
- List<X509Certificate> getTrustChain();
+ List<X509Certificate> getTrustChain() throws IOException;
/**
* Return the latest Root CA certificate known to the client.
+ *
* @return latest Root CA certificate known to the client.
*/
X509Certificate getRootCACertificate();
+ Set<X509Certificate> getAllRootCaCerts();
Review Comment:
Can you please add API doc to here as well please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
