hemantk-12 commented on code in PR #4678:
URL: https://github.com/apache/ozone/pull/4678#discussion_r1223542395
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -479,13 +477,16 @@ private SnapshotDiffReportOzone createPageResponse(
* service and throws the exception to client.
*/
private void checkReportsIntegrity(final SnapshotDiffJob diffJob,
- final int totalDiffEntries)
+ final int pageStartIdx,
+ final int numberOfEntriesInPage)
throws IOException {
- if (diffJob.getTotalDiffEntries() != totalDiffEntries) {
- LOG.error("Expected TotalDiffEntries: {} but found only " +
+ if (pageStartIdx >= diffJob.getTotalDiffEntries() &&
Review Comment:
nit: please add `()` between `||` statements.
```
if ((pageStartIdx >= diffJob.getTotalDiffEntries() &&
numberOfEntriesInPage != 0) || (pageStartIdx <
diffJob.getTotalDiffEntries() && numberOfEntriesInPage == 0)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
