adoroszlai commented on code in PR #4865:
URL: https://github.com/apache/ozone/pull/4865#discussion_r1226630698
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java:
##########
@@ -370,12 +378,6 @@ public void ensureSnapshotAddress()
"a bucket name. Only a snapshot name with " +
"a snapshot indicator is accepted");
}
- } else if (volumeName.length() == 0) {
- throw new OzoneClientException(
- "Volume name is missing.");
- } else if (bucketName.length() == 0) {
- throw new OzoneClientException(
- "Bucket name is missing.");
Review Comment:
Please don't remove these. We should accept "volume or bucket" address only
for `key list`, not for other commands that use `SnapshotUri`.
`ListKeyHandler` should no longer extend `BucketSnapshotHandler`, rather the
more generic `Handler`, and have custom address handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
