ashishkumar50 commented on code in PR #4865:
URL: https://github.com/apache/ozone/pull/4865#discussion_r1229152579


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/ListKeyHandler.java:
##########
@@ -49,6 +49,15 @@ public class ListKeyHandler extends BucketSnapshotHandler {
   protected void execute(OzoneClient client, OzoneAddress address)
       throws IOException, OzoneClientException {
 
+    if (!Strings.isNullOrEmpty(address.getBucketName())) {
+      listKeysInsideBucket(client, address);
+      return;
+    }
+    listKeysInsideVolume(client, address);
+  }
+
+  private void listKeysInsideBucket(OzoneClient client, OzoneAddress address)
+      throws IOException {
     String volumeName = address.getVolumeName();
     String bucketName = address.getBucketName();
     String snapshotNameWithIndicator = address.getSnapshotNameWithIndicator();

Review Comment:
   It will not list snapshots when listing at volume or bucket level.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to