swamirishi commented on code in PR #4875:
URL: https://github.com/apache/ozone/pull/4875#discussion_r1226841403
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java:
##########
@@ -53,7 +54,8 @@
/**
* ManagedSstFileReader tests.
*/
-public class TestManagedSstFileReader {
+@Native(ROCKS_TOOLS_NATIVE_LIBRARY_NAME)
Review Comment:
@Native(ROCKS_TOOLS_NATIVE_LIBRARY_NAME) should be only tests inside
hdds-rocks-native other modules using this library will have the library from
either of the jars.
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java:
##########
@@ -53,7 +54,8 @@
/**
* ManagedSstFileReader tests.
*/
-public class TestManagedSstFileReader {
+@Native(ROCKS_TOOLS_NATIVE_LIBRARY_NAME)
Review Comment:
The annotation shouldn't be here I believe this test should just use the jar
either from the apache maven repo or the one built in this run. I believe we
shouldn't tag this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
