adoroszlai commented on code in PR #4875:
URL: https://github.com/apache/ozone/pull/4875#discussion_r1227086063


##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java:
##########
@@ -53,7 +54,8 @@
 /**
  * ManagedSstFileReader tests.
  */
-public class TestManagedSstFileReader {
+@Native(ROCKS_TOOLS_NATIVE_LIBRARY_NAME)

Review Comment:
   > this test should just use the jar either from the apache maven repo or the 
one built in this run
   
   The point of the change is to avoid building the native library for all 
checks except the `native` one.  The `@Native` tag is added to ensure that this 
test is run in the `native` check and no other checks.  All test classes with 
`loadLibrary(ROCKS_TOOLS_NATIVE_LIBRARY_NAME)` have to be tagged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to