sodonnel commented on code in PR #4904:
URL: https://github.com/apache/ozone/pull/4904#discussion_r1231126314
##########
hadoop-ozone/dist/src/main/compose/ozone/test-ec.sh:
##########
@@ -37,6 +37,7 @@ execute_robot_test scm -v PREFIX:${prefix} -N
read-4-datanodes ec/read.robot
docker-compose up -d --no-recreate --scale datanode=3
execute_robot_test scm -v PREFIX:${prefix} -N read-3-datanodes ec/read.robot
docker-compose up -d --no-recreate --scale datanode=5
+execute_robot_test scm -v container:1 -v count:5 -N EC-recovery
replication/wait.robot
Review Comment:
If the cluster is originally 5 nodes, then it is scaled to 4, then 3 to test
the reads for online recovery. Then we scale it back to 5 - will that bring
back existing nodes that already had replicas? If so, this will not really test
reconstruction as it will be just the DNs reporting in with their existing
replicas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
