adoroszlai commented on code in PR #4904:
URL: https://github.com/apache/ozone/pull/4904#discussion_r1231229181
##########
hadoop-ozone/dist/src/main/compose/ozone/test-ec.sh:
##########
@@ -37,6 +37,7 @@ execute_robot_test scm -v PREFIX:${prefix} -N
read-4-datanodes ec/read.robot
docker-compose up -d --no-recreate --scale datanode=3
execute_robot_test scm -v PREFIX:${prefix} -N read-3-datanodes ec/read.robot
docker-compose up -d --no-recreate --scale datanode=5
+execute_robot_test scm -v container:1 -v count:5 -N EC-recovery
replication/wait.robot
Review Comment:
No, `down`/`up` creates completely new instances of the datanode service.
The `--no-recreate` option is required to avoid recreating the running
containers (SCM, datanodes 1-3, etc.).
To restart the same nodes (which is not what we want here), one has to use
`stop` and `start` commands (used in the `ozone-topology` test).
This can be confirmed by stopping replication manager, starting the 2 new
nodes, and checking container dir is empty on datanode 4 and 5.
Also confirmed by the reconstruction task messages in datanode log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
