ashishkumar50 commented on PR #4842: URL: https://github.com/apache/ozone/pull/4842#issuecomment-1596463491
> If the command always fails if --skipTrash is not provided then that argument is redundant. I think the confirmation message should specify that there is no trash recovery for FSO buckets when this command is used, then -y or user input becomes the manual override required. > > Also I don't think the recently added `ozone sh key delete --skipTrash` option should be present either. I had a discussion with @swamirishi where this flag seemed to imply that OBS buckets had trash if the flag was not used. I think `ozone sh key delete` should always go to trash on FSO bucket and if --skipTrash is needed, the user should use ofs. > > Incorporating these two suggestions together provides a consistent experience across the two commands without redundant arguments implying that trash exists where it does not. Removed -skipTrash option, instead showing in interactive description. Updated the change in PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
