ashishkumar50 commented on PR #4842: URL: https://github.com/apache/ozone/pull/4842#issuecomment-1600290717
> > ozone sh volume delete -r=yes -id localhost:9862 o3://localhost:9862/vol2 > > Volume vol2 is deleted > > I think the override should be a separate flag, not an argument to -r. When in doubt, look at existing CLIs for the intuitive thing to do. `rm -r` requires `-f` to bypass the prompt. `pacman` uses `--noconfirm`, `apt` requires `-y` etc. Just a few examples I could think of off the top of my head. Something like `--yes/-y` seems more in line with standards than `-r=yes`. > > > ozone sh volume delete -r -id localhost:9862 o3://localhost:9862/vol1 > > Enter value for -r (This command will delete volume recursively. > > There is no trash recovery for FSO buckets using this command. > > Delay is expected running this command. > > Enter 'yes' to proceed): no > > VOLUME_NOT_EMPTY > > This should probably also specify that there is no recovery option for OBS buckets either, although we don't have that anyways. Maybe a message like "There is no recovery option after using this command, and no trash for FSO buckets" would help. > > Also, is there a follow up PR to implement recursive bucket delete as well? I have updated with separate flag to override. Updated user interactive message. Yes I will have a follow up PR for recursive volume delete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
