ChenSammi commented on code in PR #4921:
URL: https://github.com/apache/ozone/pull/4921#discussion_r1234962358
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -472,31 +470,6 @@ public static SCMSecurityProtocolClientSideTranslatorPB
getScmSecurityClient(
ugi == null ? UserGroupInformation.getCurrentUser() : ugi));
}
- public static SCMSecurityProtocolClientSideTranslatorPB
Review Comment:
@fapifta , I didn't see obvious benefit of moving this
getScmSecurityClientWithFixedDuration from HddsServerUtil.java to
HASecurityUtils, could you explain it a bit? Changing this function location,
cause a lot of changes in DefaultCertificateClient and HddsDatanodeService.
If there is no obvious benefit, I would strongly suggest keep the function in
this file, so that all other service modules can call this function, instead of
now, only the scm module can call this function.
Others looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
