ChenSammi commented on code in PR #4921:
URL: https://github.com/apache/ozone/pull/4921#discussion_r1235209850
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -472,31 +470,6 @@ public static SCMSecurityProtocolClientSideTranslatorPB
getScmSecurityClient(
ugi == null ? UserGroupInformation.getCurrentUser() : ugi));
}
- public static SCMSecurityProtocolClientSideTranslatorPB
Review Comment:
@fapifta , Yeah, I mean getScmSecurityClientWithMaxRetry, not
getScmSecurityClientWithFixedDuration. To support every service can have
different scm client retires, timeouts, we can just override the
getScmSecureClient() function, I just did it in SCMCertificateClient:)
I still think it would better to handle the scm client creation in
Certificate client internally, instead of now every time, it need create the
scm client before instantiate a certificate client, avoiding many duplicate
codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
