fapifta commented on code in PR #4934:
URL: https://github.com/apache/ozone/pull/4934#discussion_r1235056345
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerSecurityProtocol.proto:
##########
@@ -195,6 +200,15 @@ message SCMListCertificateResponseProto {
repeated string certificates = 2;
}
+message SCMGetAllRootCaCertificatesResponseProto {
+ enum ResponseCode {
Review Comment:
In the general SCMSecurityRequest/Response where we have the different
request/Response types, and where you have added this protocol message as
optional on the 11th position in line 86, we have a couple of fields: success,
message, Status. I believe we should use that to convey success or failure
related information, the submitRequest method on the client side, and the
request handling on the server has the facilities to deal with errors and
succes via these. Can you please use those instead of a specific ResponseCode
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
