Galsza commented on code in PR #4934:
URL: https://github.com/apache/ozone/pull/4934#discussion_r1235275535
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerSecurityProtocol.proto:
##########
@@ -195,6 +200,15 @@ message SCMListCertificateResponseProto {
repeated string certificates = 2;
}
+message SCMGetAllRootCaCertificatesResponseProto {
+ enum ResponseCode {
Review Comment:
I'm not sure if I managed to resolve this successfully. Do I understand it
correctly that these specific response codes should only be used when we want
to specify something that is not already covered in SCMSecurityRequest/Response?
Now the command type is set according to the rest of the examples and the
ResponseCode handling should be dealt with in the central location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
