tanvipenumudy commented on code in PR #4978:
URL: https://github.com/apache/ozone/pull/4978#discussion_r1244676509
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -268,6 +268,7 @@ public static boolean isReadOnly(
case SnapshotDiff:
case ListSnapshotDiffJobs:
case TransferLeadership:
+ case TestUnknownCommand:
Review Comment:
Hi, I have set it as a read-only request to avoid the need for explicit
request/response handling associated with a write request.
Not setting it under either option is causing the
`TestOzoneManagerRatisServer#testIsReadOnlyCapturesAllCmdTypeEnums` test case
to fail where we are expected to either categorize the Type Enums as a read
request or a write request.
Do you suggest we modify the test case to avoid this one request (since we
are reserving this `cmdType` for testing purposes only)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
