Xushaohong commented on code in PR #4978:
URL: https://github.com/apache/ozone/pull/4978#discussion_r1244737956
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -268,6 +268,7 @@ public static boolean isReadOnly(
case SnapshotDiff:
case ListSnapshotDiffJobs:
case TransferLeadership:
+ case TestUnknownCommand:
Review Comment:
>> Do you suggest we modify the test case to avoid this one request (since
we are reserving this cmdType for testing purposes only)?
Yes, you could also add a comment to point out this specific case.
The test on both ratis and non-ratis env should be useful.
This PR could prevent hacked client request attacks to some extent.
(possibly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
