errose28 commented on PR #4972: URL: https://github.com/apache/ozone/pull/4972#issuecomment-1615137197
> @sumitagrawl thanks work on this. > > If a data node process dies during the execution of deleting a container, will the subsequent startup of the data node continue to delete the container and is this operation asynchronous? Will it affect the startup speed? Hi @guohao-rosicky thanks for reviewing the change. The first step of the delete process after this change is to update the container state to DELETED in the container file, which allows the datanode to finish the delete on restart if it failed partway through earlier. The way the change was written at the time of your comment may have affected startup speed slightly since it was doing a single threaded iteration of all containers in memory. However, with [this suggested change](https://github.com/apache/ozone/pull/4972#discussion_r1248229798) there should be no startup impact, because the deletion would be done as part of the existing container set construction on startup. This existing process uses one thread per volume to build up the datanode's in memory set of containers based on those that are present on the disks, and is a pre-requisite to the datanode startup completing. Delete failure should be uncommon so handling them when they are seen on restart in this area should no t affect startup time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
