sumitagrawl commented on code in PR #4972:
URL: https://github.com/apache/ozone/pull/4972#discussion_r1260656619


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java:
##########
@@ -232,4 +240,20 @@ public void verifyAndFixupContainerData(ContainerData 
containerData)
           ContainerProtos.Result.UNKNOWN_CONTAINER_TYPE);
     }
   }
+
+  private void cleanupDeletedContainer(

Review Comment:
   normal delete, db cleanup and move is done within lock. But deleted 
directory is done outside lock. So these 2 steps can not be combined here as no 
lock required here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to