swamirishi commented on code in PR #5008:
URL: https://github.com/apache/ozone/pull/5008#discussion_r1251555536
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -695,40 +696,25 @@ static List<ColumnFamilyDescriptor> getCFDescriptorList(
/**
* Read the current Live manifest for a given RocksDB instance (Active or
* Checkpoint).
- * @param dbPathArg path to a RocksDB directory
+ * @param rocksDB open rocksDB instance.
* @return a list of SST files (without extension) in the DB.
*/
- public HashSet<String> readRocksDBLiveFiles(String dbPathArg) {
- ManagedRocksDB rocksDB = null;
+ public HashSet<String> readRocksDBLiveFiles(ManagedRocksDB rocksDB) {
HashSet<String> liveFiles = new HashSet<>();
- final ColumnFamilyOptions cfOpts = new ColumnFamilyOptions();
- final List<ColumnFamilyDescriptor> cfDescriptors =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
