hemantk-12 commented on code in PR #5008:
URL: https://github.com/apache/ozone/pull/5008#discussion_r1249009133
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -113,8 +116,16 @@ private class SstFilteringTask implements BackgroundTask {
@Override
public BackgroundTaskResult call() throws Exception {
+ Optional<SnapshotCache> snapshotCache = Optional.ofNullable(ozoneManager)
+ .map(OzoneManager::getOmSnapshotManager)
+ .map(OmSnapshotManager::getSnapshotCache);
+ if (!snapshotCache.isPresent()) {
Review Comment:
Yes, I understand that. But my point is if you expect cache to be non-null
then it should be handle properly. If you are sure that cache is only null when
snapshot is disable then it is fine as I said earlier. But if not, then we
should throw an exception when cache is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
