sumitagrawl commented on code in PR #4995:
URL: https://github.com/apache/ozone/pull/4995#discussion_r1252916996
##########
hadoop-ozone/dist/src/shell/ozone/ozone:
##########
@@ -121,6 +121,7 @@ function ozonecmd_case
ozone_deprecate_envvar HDDS_DN_OPTS OZONE_DATANODE_OPTS
OZONE_DATANODE_OPTS="${RATIS_OPTS} ${OZONE_DATANODE_OPTS}"
OZONE_DATANODE_OPTS="-Dlog4j.configurationFile=${OZONE_CONF_DIR}/dn-audit-log4j2.properties
${OZONE_DATANODE_OPTS}"
+
OZONE_DATANODE_OPTS="-Dlog4j.configurationFile=${OZONE_CONF_DIR}/dn-container-log4j2.properties
${OZONE_DATANODE_OPTS}"
Review Comment:
It will take first or last occurance of configuration, but do not merge both
configuration. IMO, it should be comma separated list. Also check if both logs
are commit at same point of time, like merge, instead of overwrite for global
configuration
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java:
##########
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package org.apache.hadoop.ozone.container.common.utils;
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.hadoop.ozone.container.common.impl.ContainerData;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.hadoop.ozone.container.common.interfaces.Container.ScanResult;
+
+/**
+ * Utility class defining methods to write to the datanode container log.
+ *
+ * The container log contains brief messages about container replica level
+ * events like state changes or replication/reconstruction. Messages in this
+ * log are minimal, so it can be used to track the history of every container
+ * on a datanode for a long period of time without rolling off.
+ *
+ * All messages should be logged after their corresponding event succeeds, to
+ * prevent misleading state changes or logs filling with retries on errors.
+ * Errors and retries belong in the main datanode application log.
+ */
+public final class ContainerLogger {
+
+ @VisibleForTesting
+ public static final String LOG_NAME = "ContainerLog";
+ private static final Logger LOG = LoggerFactory.getLogger(LOG_NAME);
+ private static final String FIELD_SEPARATOR = " | ";
+
+ private ContainerLogger() { }
+
+ /**
+ * Logged when an open container is first created.
+ *
+ * @param containerData The container that was created and opened.
+ */
+ public static void logOpen(ContainerData containerData) {
+ LOG.info(getMessage(containerData));
+ }
+
+ /**
+ * Logged when a container is moved to the closing state.
+ *
+ * @param containerData The container that was marked as closing.
+ */
+ public static void logClosing(ContainerData containerData) {
+ LOG.info(getMessage(containerData));
+ }
+
+ /**
+ * Logged when a Ratis container is moved to the quasi-closed state.
+ *
+ * @param containerData The container that was quasi-closed.
+ * @param message The reason the container was quasi-closed, if known.
+ */
+ public static void logQuasiClosed(ContainerData containerData,
+ String message) {
+ LOG.warn(getMessage(containerData, message));
+ }
+
+ /**
+ * Logged when a container is moved to the closed state.
+ *
+ * @param containerData The container that was closed.
+ */
+ public static void logClosed(ContainerData containerData) {
+ LOG.info(getMessage(containerData));
+ }
+
+ /**
+ * Logged when a container is moved to the unhealthy state.
+ *
+ * @param containerData The container that was marked unhealthy.
+ * @param reason The reason the container was marked unhealthy.
+ */
+ public static void logUnhealthy(ContainerData containerData,
+ ScanResult reason) {
+ String message = reason.getFailureType() + " for file " +
Review Comment:
I think message from exception can be added, instead of trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
