GeorgeJahad commented on code in PR #5035:
URL: https://github.com/apache/ozone/pull/5035#discussion_r1258708697
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3577,18 +3578,24 @@ public List<OzoneAcl> getAcl(OzoneObj obj) throws
IOException {
* @return If checkpoint is installed successfully, return the
* corresponding termIndex. Otherwise, return null.
*/
- public TermIndex installSnapshotFromLeader(String leaderId) {
+ public synchronized TermIndex installSnapshotFromLeader(String leaderId) {
if (omRatisSnapshotProvider == null) {
LOG.error("OM Snapshot Provider is not configured as there are no peer "
+
"nodes.");
return null;
}
+ java.util.Optional<SstFilteringService> sstFilteringService =
+ java.util.Optional.ofNullable(
+ keyManager.getSnapshotSstFilteringService());
DBCheckpoint omDBCheckpoint;
+ sstFilteringService.ifPresent(BackgroundService::shutdown);
Review Comment:
yes, I believe the sst filtering service is already being stopped here:
https://github.com/apache/ozone/blob/ffd84e747dc43d08a23269a8f411d52fef41c432/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L3640
Why do we need to do it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
