GeorgeJahad commented on PR #5035: URL: https://github.com/apache/ozone/pull/5035#issuecomment-1629805028
This lock was meant to handle the problem that we are running into: https://github.com/apache/ozone/blob/e950ecee512fd87a9c20c233ba6ed224acd2c6e4/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java#L164 But it sounds like you have discovered that it is insufficient, because this file delete call is not synchronous: https://github.com/apache/ozone/blob/6da1b13e6fc760a4b1be349c44cb5943a8fa5cc7/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java#L985 Because the file may not be completely deleted when that call returns. Is that correct? If so, we need to understand exactly when it is safe to make a copy of the manifest and other files. How do we know that it is sufficient just to check for the non existence of the sst file, as is done here: https://github.com/apache/ozone/blob/6da1b13e6fc760a4b1be349c44cb5943a8fa5cc7/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/RdbUtil.java#L92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
