GeorgeJahad commented on PR #5035: URL: https://github.com/apache/ozone/pull/5035#issuecomment-1632819050
@swamirishi As I said above, I'm not sure the solution to the delete problem is complete. Let me ask a few questions: 1. Is the problem that this method returns before the sst file is deleted?: https://github.com/apache/ozone/blob/4aa49370b47397ceee3e7f29069195923f5b8a1e/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java#L993 2. Does the delete rename the sst file to the ldb file, and then later deletes the ldb file? 3. If so, then don't we also need to wait for the non-existance of the ldb file? 4. Does the delete do anything else? How do we know when it is complete? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
