ashishkumar50 commented on PR #5051: URL: https://github.com/apache/ozone/pull/5051#issuecomment-1632857536
> @ashishkumar50 Thanks for working over this, there is an improvement possible, BucketTable is cache CacheType.FULL_CACHE, i.e. entire bucket table is cached. So this actually do not need to check the Table over disk. > > The bug here is fixing that, if entry in disk table is present and validating with cache entry exist and reverifying with disk. But check with disk table can be avoided. @sumitagrawl, You mean for checking isVolumeEmpty we should avoid calling `isKeyPresentInTable(volumePrefix)` ? And we can just depend on cache? Old existing code was checking even in DB. Is it safe here just depend on cache and not checking on disk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
