ashishkumar50 commented on PR #5051: URL: https://github.com/apache/ozone/pull/5051#issuecomment-1633878480
> > recently we have done same for container delete, even though we have in cache that shows container is empty but still we check from db to really ensure it is empty before delete > > Only volume and bucket tables use `FULL_CACHE`, so other table may have entries not in the cache. > > [100x run passed](https://github.com/adoroszlai/hadoop-ozone/actions/runs/5537988977) with the [change](https://github.com/adoroszlai/hadoop-ozone/commit/dab1c0fac24509df0eb75c13182a34933fd6a980) @sumitagrawl suggested. > > Regular CI: https://github.com/adoroszlai/hadoop-ozone/actions/runs/5540255300 > > To be on the safe side, we can make the change in two steps (for easier revert if problems surface): first merge this one as is, then create new PR for the additional performance improvement. Ok we can do improvement in separate PR, currently we can keep as old behaviour to check both Cache and DB for bucket and key table. Later we can use just cache for bucket table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
