adoroszlai commented on code in PR #5071:
URL: https://github.com/apache/ozone/pull/5071#discussion_r1264350571
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java:
##########
@@ -109,8 +110,12 @@ public void execute(OzoneClient client, OzoneAddress
address)
}
}
- replication.fromParams(getConf()).ifPresent(config ->
- bb.setDefaultReplicationConfig(new DefaultReplicationConfig(config)));
+ ReplicationConfig replicationConfig =
+ replication.fromParamsOrConfig(getConf());
+ if (replicationConfig != null) {
+ bb.setDefaultReplicationConfig(
+ new DefaultReplicationConfig(replicationConfig));
+ }
Review Comment:
Bucket-level replication config should be set only if explicitly specified
via params. Otherwise it is left unset, and should fall back at server-side to
the cluster-level default replication setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
